Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update secops orb #287

Closed
wants to merge 2 commits into from
Closed

update secops orb #287

wants to merge 2 commits into from

Conversation

peakematt
Copy link
Contributor

Motivation / Implements

This PR updates the version of the SecOps orb used in this repo. Version 2.0.0 of the orb included an issue on the gitleaks job that prevented the job from running on PRs created from forks. The issue was caused by a default configuration in CircleCI which prevents providing secrets provided through CircleCI contexts to PRs created from forks. This default configuration is probably the correct one, so we needed up update the SecOps orb to properly operate on PRs from forks.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8c475ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 19, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8c475ca:

Sandbox Source
npm-embeddable-explorer (forked) Configuration
npm-embeddable-sandbox Configuration
maya-test-embed-next Configuration
maya-test-embed-next Configuration

@peakematt peakematt marked this pull request as ready for review October 19, 2023 19:03
@peakematt peakematt requested a review from mayakoneval October 19, 2023 19:03
@peakematt
Copy link
Contributor Author

@mayakoneval Sorry for the rapid follow-up PR on this.

@mayakoneval
Copy link
Contributor

I don't know how this went so long without me seeing it so so so sorry

@mayakoneval
Copy link
Contributor

closing as this has been updated since

@mayakoneval mayakoneval closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayakoneval mayakoneval mayakoneval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peakematt @mayakoneval